Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jul 25, 2025


PR-Codex overview

This PR focuses on refactoring the button components and form controls in the dashboard, improving the UI elements by replacing FormControl with FormFieldSetup, and updating the button usage to enhance functionality and styling.

Detailed summary

  • Changed ButtonProps interface in apps/dashboard/src/chakra/button.tsx to remove export.
  • Updated button import path in apps/dashboard/src/@/components/solidity-inputs/button.tsx.
  • Modified button properties in IpfsUploadButton for better loading state and styling.
  • Replaced FormControl with FormFieldSetup in modular-contract-default-modules-fieldset.tsx for improved form handling.
  • Updated form controls in custom-contract.tsx for consistency and better error handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Refactor

    • Unified form field presentation by replacing direct Chakra UI form controls with a custom, reusable form field component across contract deployment and module configuration forms.
    • Simplified error handling, labels, and helper text management for a more consistent user experience.
  • Style

    • Updated button styling and icon placement for IPFS upload actions, improving visual consistency and feedback during upload operations.

@vercel vercel bot temporarily deployed to Preview – wallet-ui July 25, 2025 12:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 25, 2025 12:13 Inactive
@vercel
Copy link

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2025 6:20pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 25, 2025 6:20pm
nebula ⬜️ Skipped (Inspect) Jul 25, 2025 6:20pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 25, 2025 6:20pm
wallet-ui ⬜️ Skipped (Inspect) Jul 25, 2025 6:20pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 25, 2025 12:13 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 25, 2025 12:13 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2025

⚠️ No Changeset found

Latest commit: c077f78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 25, 2025

Walkthrough

The changes refactor form field components in contract deployment and module selection forms by replacing direct Chakra UI form controls with a custom FormFieldSetup component. Additionally, the IPFS upload button is updated to use a custom UI button with revised props, styling, and icon placement. The ButtonProps interface export is removed. No business logic or exported entity signatures are altered.

Changes

File(s) Change Summary
.../contract-components/contract-deploy-form/custom-contract.tsx
.../contract-deploy-form/modular-contract-default-modules-fieldset.tsx
Replaced Chakra UI form control components with FormFieldSetup for label, helper text, error display, and layout consolidation.
.../solidity-inputs/button.tsx Changed button import to custom UI button; updated loading state handling, icon placement, variant, and styling of IPFS upload button.
.../chakra/button.tsx Removed export keyword from ButtonProps interface; no other changes to interface properties.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 031b59f and c077f78.

📒 Files selected for processing (4)
  • apps/dashboard/src/@/components/contract-components/contract-deploy-form/custom-contract.tsx (5 hunks)
  • apps/dashboard/src/@/components/contract-components/contract-deploy-form/modular-contract-default-modules-fieldset.tsx (2 hunks)
  • apps/dashboard/src/@/components/solidity-inputs/button.tsx (2 hunks)
  • apps/dashboard/src/chakra/button.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • apps/dashboard/src/chakra/button.tsx
  • apps/dashboard/src/@/components/solidity-inputs/button.tsx
  • apps/dashboard/src/@/components/contract-components/contract-deploy-form/modular-contract-default-modules-fieldset.tsx
  • apps/dashboard/src/@/components/contract-components/contract-deploy-form/custom-contract.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 07-25-dashboard_migrate_contract_deployment_ui_from_chakra_to_tailwind

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 25, 2025
@MananTank MananTank marked this pull request as ready for review July 25, 2025 12:13
@MananTank MananTank requested review from a team as code owners July 25, 2025 12:13
Copy link
Member Author

MananTank commented Jul 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.21%. Comparing base (6b7983f) to head (c077f78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7712   +/-   ##
=======================================
  Coverage   56.21%   56.21%           
=======================================
  Files         908      908           
  Lines       58236    58236           
  Branches     4205     4205           
=======================================
  Hits        32738    32738           
  Misses      25388    25388           
  Partials      110      110           
Flag Coverage Δ
packages 56.21% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.33 KB (0%) 1.3 s (0%) 200 ms (+148.83% 🔺) 1.5 s
thirdweb (cjs) 353.15 KB (0%) 7.1 s (0%) 700 ms (+17.26% 🔺) 7.8 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 75 ms (+1421.37% 🔺) 189 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 23 ms (+944.76% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 65 ms (+398.62% 🔺) 450 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 25, 2025

Merge activity

)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the button components and form controls in the dashboard application, improving the UI consistency and structure by replacing `FormControl` with a custom `FormFieldSetup` component and adjusting button properties.

### Detailed summary
- Changed the export of `ButtonProps` in `apps/dashboard/src/chakra/button.tsx` to remove the `export` keyword.
- Updated button imports in `apps/dashboard/src/@/components/solidity-inputs/button.tsx` to use the new path.
- Modified the `IpfsUploadButton` to use `variant="secondary"` and added a `disabled` state.
- Replaced `FormControl` with `FormFieldSetup` in multiple components for better structure and error handling.
- Adjusted the props passed to `FormFieldSetup` for improved clarity and functionality.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Refactor**
  * Unified form field presentation by replacing direct Chakra UI form controls with a custom, reusable form field component across contract deployment and module configuration forms.
  * Simplified error handling, labels, and helper text management for a more consistent user experience.

* **Style**
  * Updated button styling and icon placement for IPFS upload actions, improving visual consistency and feedback during upload operations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 07-25-dashboard_migrate_contract_deployment_ui_from_chakra_to_tailwind branch from 031b59f to c077f78 Compare July 25, 2025 18:11
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 25, 2025 18:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 25, 2025 18:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 25, 2025 18:12 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 25, 2025 18:12 Inactive
@graphite-app graphite-app bot merged commit c077f78 into main Jul 25, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-25-dashboard_migrate_contract_deployment_ui_from_chakra_to_tailwind branch July 25, 2025 18:21
@vercel vercel bot temporarily deployed to Production – thirdweb_playground July 25, 2025 18:21 Inactive
@vercel vercel bot temporarily deployed to Production – nebula July 25, 2025 18:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui July 25, 2025 18:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 July 25, 2025 18:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants